Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: Add validation for create/edit pool (#849426) ......................................................................
webadmin: Add validation for create/edit pool (#849426) https://bugzilla.redhat.com/849426 Leftover from already merged http://gerrit.ovirt.org/#/c/7649/ The NumOfDesktops can be String and also Integer, which caused class cast exception. This patch fixes it. Change-Id: Ieb1055ca17df9a5add167a3a6228a930a04b87f4 Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/7919/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java index 6642e3b..bed6023 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java @@ -116,7 +116,7 @@ getModel().getNumOfDesktops().ValidateEntity(new IValidation[] { new ExistingPoolNameLengthValidation( (String) getModel().getName().getEntity(), ((Integer) getModel().getAssignedVms().getEntity()) + - Integer.parseInt(((String) getModel().getNumOfDesktops().getEntity())), + Integer.parseInt((getModel().getNumOfDesktops().getEntity().toString())), (VmOsType) getModel().getOSType().getSelectedItem() ) } ); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java index 7e2f027..b90870b 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java @@ -44,7 +44,7 @@ if (getModel().getName().getIsValid()) { getModel().getName().ValidateEntity(new IValidation[] { new NewPoolNameLengthValidation( (String) getModel().getName().getEntity(), - Integer.parseInt(((String) getModel().getNumOfDesktops().getEntity())), + Integer.parseInt((getModel().getNumOfDesktops().getEntity().toString())), (VmOsType) getModel().getOSType().getSelectedItem() ) }); -- To view, visit http://gerrit.ovirt.org/7919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb1055ca17df9a5add167a3a6228a930a04b87f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
