Michael Pasternak has posted comments on this change.
Change subject: core: add max memory for scheduling VMs as a calculated field
to VDS
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
Line 168: if (entity.getvds_type() != null) {
Line 169: HostType type = map(entity.getvds_type(), null);
Line 170: model.setType(type != null ? type.value() : null);
Line 171: }
Line 172: model.setMemory(Long.valueOf(entity.getphysical_mem_mb() ==
null ? 0 : entity.getphysical_mem_mb()
no need for explicit cast as BYTES_IN_MEGABYTE is Long
Line 173: * BYTES_IN_MEGABYTE));
Line 174: model.setMaxSchedulingMemory((int)
entity.getMaxSchedulingMemory() * BYTES_IN_MEGABYTE);
Line 175: return model;
Line 176: }
Line 170: model.setType(type != null ? type.value() : null);
Line 171: }
Line 172: model.setMemory(Long.valueOf(entity.getphysical_mem_mb() ==
null ? 0 : entity.getphysical_mem_mb()
Line 173: * BYTES_IN_MEGABYTE));
Line 174: model.setMaxSchedulingMemory((int)
entity.getMaxSchedulingMemory() * BYTES_IN_MEGABYTE);
please add test for this property
Line 175: return model;
Line 176: }
Line 177:
Line 178: @Mapping(from = VDS.class, to = PowerManagement.class)
--
To view, visit http://gerrit.ovirt.org/7825
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cb338f79682bdc550c4cc6e0667ba1fea50a9c6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
