Shahar Havivi has uploaded a new change for review. Change subject: UI: when no tasks avilable dont show empty string (#854169) ......................................................................
UI: when no tasks avilable dont show empty string (#854169) https://bugzilla.redhat.com/show_bug.cgi?id=854169 Change-Id: Ia1d48ff3bff032f31f3fb5e70637dd11e401153d Signed-off-by: Shahar Havivi <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TaskFirstRowModelProvider.java 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/7924/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TaskFirstRowModelProvider.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TaskFirstRowModelProvider.java index 3b4562a..7e74306 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TaskFirstRowModelProvider.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TaskFirstRowModelProvider.java @@ -10,6 +10,12 @@ public class TaskFirstRowModelProvider extends TaskModelProvider { + private static Job emptyJob = new Job(); + private static String emptyJobMessage = "[No jobs available]"; //$NON-NLS-1$ + static { + emptyJob.setDescription(emptyJobMessage); + } + @Inject public TaskFirstRowModelProvider(ClientGinjector ginjector) { super(ginjector); @@ -17,7 +23,7 @@ @Override protected void updateDataProvider(List<Job> items) { - List<Job> firstRowData = items.isEmpty() ? items : Arrays.asList(items.get(0)); + List<Job> firstRowData = items.isEmpty() ? Arrays.asList(emptyJob) : Arrays.asList(items.get(0)); super.updateDataProvider(firstRowData); } -- To view, visit http://gerrit.ovirt.org/7924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia1d48ff3bff032f31f3fb5e70637dd11e401153d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
