Daniel Erez has posted comments on this change. Change subject: core: Add call back command for remove VM with Cinder disks ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/39229/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-26 13:03:35 +0200 Line 4: Commit: Maor Lipchuk <[email protected]> Line 5: CommitDate: 2015-03-26 13:13:52 +0200 Line 6: Line 7: core: Add call back command for remove VM with Cinder disks s/call back/callback Line 8: Line 9: Adding new call back from remove VM with Cinder disks Line 10: Line 11: Change-Id: I1e07d72543656681f4a761db629bbcbc1bb40021 Line 5: CommitDate: 2015-03-26 13:13:52 +0200 Line 6: Line 7: core: Add call back command for remove VM with Cinder disks Line 8: Line 9: Adding new call back from remove VM with Cinder disks same Line 10: Line 11: Change-Id: I1e07d72543656681f4a761db629bbcbc1bb40021 Line 12: Bug-Url: https://bugzilla.redhat.com/?????? Line 8: Line 9: Adding new call back from remove VM with Cinder disks Line 10: Line 11: Change-Id: I1e07d72543656681f4a761db629bbcbc1bb40021 Line 12: Bug-Url: https://bugzilla.redhat.com/?????? missing number https://gerrit.ovirt.org/#/c/39229/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommandCallBack.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommandCallBack.java: Line 50: CommandCoordinatorUtil.removeAllCommandsInHierarchy(cmdId); Line 51: } Line 52: Line 53: private T getCommand(Guid cmdId) { Line 54: return (T) CommandCoordinatorUtil.retrieveCommand(cmdId); you can remove casting Line 55: } -- To view, visit https://gerrit.ovirt.org/39229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e07d72543656681f4a761db629bbcbc1bb40021 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
