Omer Frenkel has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
......................................................................
Patch Set 7: (1 inline comment)
one comment inside, looks good to me, need more reviewers as this is pretty big
thing
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
Line 175: RemoveVdsDynamicFromDb(server);
Line 176: RemoveVdsStaticFromDb(server);
Line 177:
Line 178: // remove the server from resource manager
Line 179:
ResourceManager.getInstance().RemoveVds(server.getId());
please use:
Backend.getInstance().getResourceManager()
.RunVdsCommand(VDSCommandType.RemoveVds, new
RemoveVdsVDSCommandParameters(server.getId()));
Line 180:
Line 181: log.debugFormat("Server {0} has been removed directly
using the gluster CLI. Removing it from engine as well.",
Line 182: server.getvds_name());
Line 183: logServerMessage(server,
AuditLogType.GLUSTER_SERVER_REMOVED_FROM_CLI);
--
To view, visit http://gerrit.ovirt.org/7288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b61eb6e93105e46e2706eac1d94bc10717224c2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
