Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: cleanup cells -- use SafeHtmlTemplates ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39110/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LunSelectionCell.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LunSelectionCell.java: Line 25: Line 26: @Template("<input id=\"{0}\" tabindex='-1' type=\"{1}\" checked disabled />") Line 27: SafeHtml inputCheckedDisabled(String id, String type); Line 28: Line 29: @Template("<input id=\"{0}\" tabindex='-1' type=\"{1}\" />") > Can't you do something like this: Okay scratch that, SafeHtmlTemplates do not allow variables in a tag outside of quotes. So this won't work. Line 30: SafeHtml inputUnchecked(String id, String type); Line 31: Line 32: @Template("<input id=\"{0}\" tabindex='-1' type=\"{1}\" disabled />") Line 33: SafeHtml inputUncheckedDisabled(String id, String type); -- To view, visit https://gerrit.ovirt.org/39110 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab169b1daf5974655f90bab47e8ee5286c4f2e51 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
