Omer Frenkel has posted comments on this change. Change subject: core: Restrict graphics for older CC ......................................................................
Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/38274/4/packaging/conf/osinfo-defaults.properties File packaging/conf/osinfo-defaults.properties: Line 259: os.windows_8.id.value = 20 Line 260: os.windows_8.name.value = Windows 8 Line 261: os.windows_8.derivedFrom.value = windows_7 Line 262: os.windows_8.sysprepPath.value = ${ENGINE_USR}/conf/sysprep/sysprep.w8 Line 263: os.windows_8.productKey.value = i wonder if this patch will now cause win8 to support spice although it shouldn't (for example in 3.5 cluster and below..) Line 264: os.windows_8.devices.display.protocols.value = vnc/cirrus Line 265: os.windows_8.cpu.unsupported.value = conroe, opteron_g1 Line 266: Line 267: # Windows8x64(21, OsType.Windows, true), Line 268: os.windows_8x64.id.value = 21 Line 269: os.windows_8x64.name.value = Windows 8 x64 Line 270: os.windows_8x64.derivedFrom.value = windows_7x64 Line 271: os.windows_8x64.sysprepPath.value = ${ENGINE_USR}/conf/sysprep/sysprep.w8x64 Line 272: os.windows_8x64.productKey.value = same concern here Line 273: os.windows_8x64.devices.display.protocols.value = vnc/cirrus Line 274: os.windows_8x64.resources.maximum.ram.value = 524288 Line 275: os.windows_8x64.cpu.unsupported.value = conroe, opteron_g1 Line 276: os.windows_8x64.devices.hyperv.enabled.value = false Line 279: os.windows_2012x64.id.value = 23 Line 280: os.windows_2012x64.name.value = Windows 2012 x64 Line 281: os.windows_2012x64.derivedFrom.value = windows_2008x64 Line 282: os.windows_2012x64.sysprepPath.value = ${ENGINE_USR}/conf/sysprep/sysprep.2k12x64 Line 283: os.windows_2012x64.productKey.value = and here Line 284: os.windows_2012x64.devices.display.protocols.value = vnc/cirrus Line 285: os.windows_2012x64.resources.maximum.ram.value = 4194304 Line 286: os.windows_2012x64.cpu.unsupported.value = conroe, opteron_g1 Line 287: os.windows_2012x64.devices.hyperv.enabled.value = false Line 352: os.other_ppc64.devices.disk.hotpluggableInterfaces.value.3.6 = VirtIO, VirtIO_SCSI, SPAPR_VSCSI Line 353: os.other_ppc64.devices.network.hotplugSupport.value.3.3 = true Line 354: os.other_ppc64.devices.network.hotplugSupport.value.3.4 = true Line 355: os.other_ppc64.devices.network.hotplugSupport.value.3.5 = true Line 356: os.other_ppc64.devices.network.hotplugSupport.value.3.6 = true and here Line 357: os.other_ppc64.devices.display.protocols.value = vnc/vga Line 358: os.other_ppc64.devices.watchdog.models.value = i6300esb Line 359: # In the ppc64 architecture there are only three devices occupying Line 360: # virtual PCI slots in a newly created VM, the USB controller, -- To view, visit https://gerrit.ovirt.org/38274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I578b11b0a89a2660bdbe5b1eda70634064f8938e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
