Omer Frenkel has posted comments on this change. Change subject: engine: Phase 4: Query for generating console descriptor ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/37975/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleDescriptorGenerator.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleDescriptorGenerator.java: Line 4: import org.ovirt.engine.core.compat.StringHelper; Line 5: Line 6: public class ConsoleDescriptorGenerator { Line 7: Line 8: public static String generateDescriptor(ConsoleOptions options) { please remove all non-nls comments Line 9: StringBuilder configBuilder = new StringBuilder("[virt-viewer]"); //$NON-NLS-1$ Line 10: configBuilder.append("\ntype=").append(graphicsTypeToString(options.getGraphicsType())) //$NON-NLS-1$ Line 11: .append("\nhost=").append(options.getHost()) //$NON-NLS-1$ Line 12: .append("\nport=").append(options.getPort()) //$NON-NLS-1$ -- To view, visit https://gerrit.ovirt.org/37975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a0f882f8936fe49d7231eb42d67fe374e28ccb5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
