Kanagaraj M has posted comments on this change. Change subject: webadmin : Create + Delete Geo-rep session ......................................................................
Patch Set 48: (2 comments) https://gerrit.ovirt.org/#/c/29691/48/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupPresenterWidget.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupPresenterWidget.java: Line 44: model.getSlaveUserName().getEntityChangedEvent().addListener(new IEventListener<EventArgs>() { : @Override : public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { : String slaveUser = model.getSlaveUserName() : .getEntity(); : getView().setUserGroupVisibility(slaveUser != null && !slaveUser : .equalsIgnoreCase(ConstantsManager.getInstance().getConstants().rootUser())); : } : }); You could do this in the model itself because userGroup is already represented in model. getSlaveUserGroupName().setIsChangeable() can be used to make the ui-editor to enable or disable. https://gerrit.ovirt.org/#/c/29691/48/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupView.java: Line 202: @Override : public void setUserGroupVisibility(boolean readOnly) { : slaveUserGroupNameEditor.setEnabled(readOnly); : } This may not be required, since this editor binds to a model property. You could just work with that property to make the editor behave the way you want -- To view, visit https://gerrit.ovirt.org/29691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied7317d456bf66db9a7800ba7106f2e8ec66429c Gerrit-PatchSet: 48 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
