anmolbabu has posted comments on this change. Change subject: engine : Geo-rep JsonRpc refactored ......................................................................
Patch Set 6: (4 comments) https://gerrit.ovirt.org/#/c/39250/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java: Line 41: } Line 42: Line 43: @Override Line 44: protected boolean canDoAction() { Line 45: setGlusterVolumeId(getParameters().getVolumeId() == null ? getGeoRepSession().getMasterVolumeId() : getParameters().getVolumeId()); > can you do this if getGlusterVolumeId is null? wouldn't the setGlusterVolum Done Line 46: if (!super.canDoAction()) { Line 47: return false; Line 48: } Line 49: if (getGeoRepSession().getStatus().equals(GeoRepSessionStatus.ACTIVE)) { https://gerrit.ovirt.org/#/c/39250/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteGlusterVolumeGeoRepSessionVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteGlusterVolumeGeoRepSessionVDSCommand.java: Line 15: @Override Line 16: protected void executeVdsBrokerCommand() { Line 17: status = getBroker().glusterVolumeGeoRepSessionDelete(getParameters().getVolumeName(), Line 18: getParameters().getSlaveHost(), Line 19: getParameters().getSlaveVolume(), null); > getParameters().getUserName() ? Done Line 20: // Handle errors if any Line 21: proceedProxyReturnValue(); Line 22: Line 23: } https://gerrit.ovirt.org/#/c/39250/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepConfigListVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepConfigListVDSCommand.java: Line 20: } Line 21: Line 22: @Override Line 23: protected void executeVdsBrokerCommand() { Line 24: result = getBroker().glusterVolumeGeoRepConfigList(getParameters().getVolumeName(), getParameters().getSlaveHost(), getParameters().getSlaveVolume(), null); > getParameters().getUserName() ? Done Line 25: proceedProxyReturnValue(); Line 26: List<GlusterGeoRepSessionConfiguration> sessionConfigs = result.getSessionConfig(); Line 27: setReturnValue(sessionConfigs); Line 28: } https://gerrit.ovirt.org/#/c/39250/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterVolumeGeoRepSessionVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterVolumeGeoRepSessionVDSCommand.java: Line 15: protected void executeVdsBrokerCommand() { Line 16: status = getBroker().glusterVolumeGeoRepSessionStop(getParameters().getVolumeName(), Line 17: getParameters().getSlaveHost(), Line 18: getParameters().getSlaveVolume(), Line 19: null, getParameters().getForce()); > shouldn't this be getParameters().getUserName? Done Line 20: // Handle errors if any Line 21: proceedProxyReturnValue(); Line 22: Line 23: } -- To view, visit https://gerrit.ovirt.org/39250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6354afa4e543fc6e3a8fe669f37ffaee400c53 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
