Liran Zelkha has posted comments on this change. Change subject: core: Make DAOs injectable ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/38505/5/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java: Line 48: TransactionConfiguration > Isn't that redundant? The supplied argument values are same as the defaults Done https://gerrit.ovirt.org/#/c/38505/5/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BookmarkDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BookmarkDAOTest.java: Line 134: Bookmark result = dao.get(existing_bookmark.getbookmark_id()); Line 135: Line 136: assertNull(result); Line 137: } Line 138: > Please remove this line (or alternatively checkout the master version of th Done -- To view, visit https://gerrit.ovirt.org/38505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic426126d690ab6dedb49ef6b67deeba67661d031 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
