Hello Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/39353
to review the following change.
Change subject: engine: Fix db scheduler test
......................................................................
engine: Fix db scheduler test
The tests fails periodically due to the
timing between quartz scheduler thread and main thread
Increased sleep duration in main thread.
Change-Id: I2ff92a2331dfa3ac7d99e4ef8d858b21f1ffda05
Signed-off-by: Sahina Bose <[email protected]>
---
M
backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImplTest.java
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/39353/1
diff --git
a/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImplTest.java
b/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImplTest.java
index dfda3b8..75f9e95 100644
---
a/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImplTest.java
+++
b/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImplTest.java
@@ -68,11 +68,12 @@
new Class[] { String.class },
new Object[] { "scheduleARecurringJob" }, "0/1 * * * * ?");
- Thread.sleep(100);
+ TimeUnit.SECONDS.sleep(2);
try {
JobDetail job =
scheduler.getRawScheduler().getJobDetail(JobKey.jobKey(jobName));
assertNotNull(job);
List<? extends Trigger> triggers =
scheduler.getRawScheduler().getTriggersOfJob(JobKey.jobKey(jobName));
+ // Following assertion fails periodically due to race condition
assertNotNull(triggers.get(0).getPreviousFireTime());
} catch (SchedulerException e) {
fail("Unexpected exception occured -" + e.getMessage());
--
To view, visit https://gerrit.ovirt.org/39353
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ff92a2331dfa3ac7d99e4ef8d858b21f1ffda05
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
