Alon Bar-Lev has posted comments on this change. Change subject: hosted-engine: allow to deploy hosted-engine ......................................................................
Patch Set 17: (3 comments) https://gerrit.ovirt.org/#/c/38547/17/src/plugins/ovirt-host-deploy/hosted-engine/packages.py File src/plugins/ovirt-host-deploy/hosted-engine/packages.py: Line 83: ) Line 84: def _closeup(self): Line 85: ha_services = ('ovirt-ha-agent',) Line 86: if not self.services.supportsDependency: Line 87: ha_services = ('ovirt-ha-broker', 'ovirt-ha-agent') append only ovirt-ha-broker? but we do control this ovirt-ha-agent service, so we can make sure it starts dependencies in sysvinit. Line 88: for service in ha_services: Line 89: self.services.startup( Line 90: name=service, Line 91: state=self.environment[ Line 89: self.services.startup( Line 90: name=service, Line 91: state=self.environment[ Line 92: odeploycons.HostedEngineEnv.ENABLE Line 93: ], this should be done only for root service, please notice that due to ordering you will anyway have a period in which the dependency is not started, so better to handle this again in package. Line 94: ) Line 95: self.services.state( Line 96: name=service, Line 97: state=False, Line 95: self.services.state( Line 96: name=service, Line 97: state=False, Line 98: ) Line 99: if self.environment[odeploycons.HostedEngineEnv.ENABLE]: all this sequence should be done only if enable... we should not touch anything otherwise. Line 100: self.services.state( Line 101: name=service, Line 102: state=True, Line 103: ) -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
