Ondřej Macháček has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/37886/15/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java: Line 57: usage = "__single__"; Line 58: } else { Line 59: usage = args.remove(0); Line 60: argMap.put("__action__", usage); Line 61: } > I do not understand. 'a prefix within property file' == subaction , right? So I need the subaction in this ParametersParser class, right? So I can: 1. pass the subaction in as method arg. (you said in previous patch that I shouldn't) 2. get it from argument list, as I do right now. Or any other solution I can fetch subaction from this class? Line 62: if(usage.equals("--help") || (!usage.equals("__single__") && !args.isEmpty() && args.contains("--help"))) { Line 63: throw new ExitException(getHelp(), 0, true); Line 64: } Line 65: -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ondra Machacek <[email protected]> Gerrit-Reviewer: Ondřej Macháček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
