Liron Aravot has posted comments on this change.

Change subject: core: prevent simultaneous ReconstructsMasterDomain on the same 
pool(#845838)
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 265:     }
Line 266: 
Line 267:     @Override
Line 268:     protected Map<String, String> getSharedLocks() {
Line 269:         return null;
no, because taking the locks as its implemented in this method in the parent 
class will cause to deadlock. it must be overridden.
Line 270:     }
Line 271: 
Line 272:     @Override
Line 273:     public AuditLogType getAuditLogTypeValue() {


--
To view, visit http://gerrit.ovirt.org/7964
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99393aea692a1bb2c6b6cb0b07329275bd3e7b7f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to