Sandro Bonazzola has posted comments on this change. Change subject: reorg repoclosure script for ease of maintenance ......................................................................
Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/39249/5/jobs/packaging/repo_closure_check.sh File jobs/packaging/repo_closure_check.sh: Line 27: die() { Line 28: local msg="${1}" Line 29: echo "FATAL: ${msg}" Line 30: if [[ ${TEST_RUN} -eq 0 ]]; then Line 31: # This is not test, so do exit please use spaces here Line 32: exit 1 Line 33: fi Line 34: } Line 35: Line 372: "check-updates-testing-${distid},baseurl,${FEDORA_MIRROR}/fedora/updates/testing/${distro_ver}/x86_64/" Line 373: "check-patternfly-${distid},baseurl,${COPR}/patternfly/patternfly1/fedora-${distro_ver}-x86_64/" Line 374: "check-glusterfs-fedora-${distid}-nightly,baseurl,${GLUSTER_MIRROR}/pub/gluster/glusterfs/nightly/glusterfs/fedora-${distro_ver}-x86_64/" Line 375: "check-glusterfs-fedora-${distid},baseurl,${GLUSTER_MIRROR}/pub/gluster/glusterfs/LATEST/Fedora/fedora-${distro_ver}/x86_64/" Line 376: "check-glusterfs-fedora-noarch-${distid},baseurl,${GLUSTER_MIRROR}/pub/gluster/glusterfs/LATEST/Fedora/fedora-${distro_ver}/noarch/" please be sure to add virt-preview on rebase. Line 377: ) Line 378: Line 379: ;; Line 380: *) die "Distribution: ${distro} is unsupported" ;; Line 402: get_opts "${@}" Line 403: validation Line 404: check_layout Line 405: # TODO: delete old code Line 406: # check_repo_closure why keeping this todo instead of doing? Line 407: check_repo_closure_new "${DISTRIBUTION}" "${DISTRIBUTION_VERSION}" Line 408: } Line 409: Line 410: if [[ ${TEST_RUN} -eq 0 ]]; then https://gerrit.ovirt.org/#/c/39249/5/jobs/packaging/test_repo_closure_check.sh File jobs/packaging/test_repo_closure_check.sh: Line 20: unset FEDORA_MIRROR Line 21: unset GLUSTER_MIRROR Line 22: unset JPACKAGE_MIRROR Line 23: unset COPR Line 24: ## check non existing vars have been set: trailing spaces above Line 25: validation Line 26: [ ! -z "${BASE_URL}" ] Line 27: [ ! -z "${CENTOS_MIRROR}" ] Line 28: [ ! -z "${EPEL_MIRROR}" ] -- To view, visit https://gerrit.ovirt.org/39249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I207c5c59ca3149c17897c231e391e15e7eec4363 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Max Kovgan <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Max Kovgan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
