Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: allow tuning dump/restore ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/39190/6/packaging/setup/ovirt_engine_setup/engine_common/database.py File packaging/setup/ovirt_engine_setup/engine_common/database.py: Line 239: return self._plugin.dialog Line 240: Line 241: def _ind_env(self, keykey): Line 242: return self.environment[self._dbenvkeys[keykey]] Line 243: Maybe define it as static or classmethod to avoid twice definition? Line 244: def __init__( Line 245: self, Line 246: plugin, Line 247: dbenvkeys, -- To view, visit https://gerrit.ovirt.org/39190 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99de636d4da15a253f2186084902f0f133603f4d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
