Martin Peřina has uploaded a new change for review.

Change subject: core: Skip restart of host if PM is disabled for it
......................................................................

core: Skip restart of host if PM is disabled for it

Fixes non responding treatment flow to not execute Kdump detection and
PM restart of the host if PM is disabled for the host. That bug was
introduced in patch I99770873470541bc7f6c3a7338f4bcc10f5e4fb3.

Change-Id: Ib5763efcb0a14abacb77f48d3912678e651bdeed
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/39407/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
index 40f191c..3b8287c 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
@@ -126,10 +126,12 @@
                 return;
             }
 
-            // proceed with non responding treatment only if PM action are 
allowed
-            if 
(!MonitoringStrategyFactory.getMonitoringStrategyForVds(getVds()).isPowerManagementSupported())
 {
+            // proceed with non responding treatment only if PM action are 
allowed and PM enabled for host
+            if 
(!MonitoringStrategyFactory.getMonitoringStrategyForVds(getVds()).isPowerManagementSupported()
+                    || !getVds().isPmEnabled()) {
                 setSucceeded(false);
                 setCommandShouldBeLogged(false);
+                return;
             }
 
             retVal = runInternalAction(VdcActionType.VdsKdumpDetection,


-- 
To view, visit https://gerrit.ovirt.org/39407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5763efcb0a14abacb77f48d3912678e651bdeed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to