Hello Yair Zaslavsky,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/7988
to review the following change.
Change subject: core: Making NGuid implement Comparable(#852451)
......................................................................
core: Making NGuid implement Comparable(#852451)
Changing NGuid to implement Comparable.
Comparison is based on java.util.UUID
comparison algorithm
Change-Id: I05680581ff14ac916e4d9d559476dfb4683ed229
Signed-off-by: Yair Zaslavsky <[email protected]>
---
M
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NGuid.java
A
backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/NGuidTest.java
2 files changed, 26 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/7988/1
diff --git
a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NGuid.java
b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NGuid.java
index 0df89ce..f0fadb9 100644
---
a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NGuid.java
+++
b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NGuid.java
@@ -2,7 +2,7 @@
import java.util.UUID;
-public class NGuid implements Serializable {
+public class NGuid implements Serializable, Comparable<NGuid> {
protected static final String EMPTY_GUID_VALUE =
"00000000-0000-0000-0000-000000000000";
@@ -155,4 +155,9 @@
.toHexString(k);
}
+ @Override
+ public int compareTo(NGuid rhs) {
+ return this.getUuid().compareTo(rhs.getUuid());
+ }
+
}
diff --git
a/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/NGuidTest.java
b/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/NGuidTest.java
new file mode 100644
index 0000000..e8f8430
--- /dev/null
+++
b/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/NGuidTest.java
@@ -0,0 +1,20 @@
+package org.ovirt.engine.core.compat;
+import static org.junit.Assert.*;
+
+import org.junit.Test;
+
+/**
+ * Tests NGuid functionality
+ */
+public class NGuidTest {
+
+ @Test
+ public void testCompareTo() {
+ NGuid guid1 =
NGuid.createGuidFromString("5b411bc1-c220-4421-9abd-cfa484aecb6e");
+ NGuid guid2 =
NGuid.createGuidFromString("5b411bc1-c220-4421-9abd-cfa484aecb6f");
+ assertTrue(guid1.compareTo(guid2) < 0);
+ assertTrue(guid1.compareTo(guid1) == 0);
+ assertTrue(guid2.compareTo(guid1) > 0);
+ }
+
+}
--
To view, visit http://gerrit.ovirt.org/7988
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05680581ff14ac916e4d9d559476dfb4683ed229
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
