Vered Volansky has posted comments on this change. Change subject: core: Remove constant SIZE_IS_NOT_AVAILABLE ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/39004/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java: Line 657: VDSReturnValue returnValue; Line 658: Line 659: if (repoStorageDomainId != null) { Line 660: try { Line 661: StoragePool dc = getStoragePoolDAO().get(repoStoragePoolId); > Please add a TODO comment that says we should remove this condition once we I don't this is related to this patch. I will gladly add a patch with this comment. Agreed? Line 662: if (FeatureSupported.getFileStats(dc.getCompatibilityVersion())) { Line 663: returnValue = Backend Line 664: .getInstance() Line 665: .getResourceManager() -- To view, visit https://gerrit.ovirt.org/39004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida18353f1d5c976ee70e65045b80410dded2bb1f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
