Lior Vernia has posted comments on this change. Change subject: webadmin: add showErrorDialog property to runMultipleAction ......................................................................
Patch Set 8: Code-Review+2 (2 comments) Mostly looks good, please note javadoc inconsistencies. https://gerrit.ovirt.org/#/c/37722/8/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java: Line 485: * @param actionType The action type of the actions to run. Line 486: * @param parameters The parameters to the actions. Line 487: * @param callback The callback to call after the operation happens. Line 488: * @param state A state object. Line 489: * @param showErrorDialog Should we show an error dialog? Javadoc out-of-date. Line 490: */ Line 491: public void runMultipleAction(final VdcActionType actionType, Line 492: final List<VdcActionParametersBase> parameters, Line 493: final IFrontendMultipleActionAsyncCallback callback, Line 521: * @param actionType The type of action to perform. Line 522: * @param parameters The parameters of the action. Line 523: * @param showErrorDialog Should we show an error dialog? Line 524: */ Line 525: public void runMultipleAction(final VdcActionType actionType, Javadoc missing callback parameter. Line 526: final List<VdcActionParametersBase> parameters, Line 527: final IFrontendMultipleActionAsyncCallback callback, Line 528: final boolean showErrorDialog) { Line 529: runMultipleAction(actionType, parameters, false, callback, null, showErrorDialog); -- To view, visit https://gerrit.ovirt.org/37722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I703c95dd2c8bfc2ff3cc997019dcd15fd671d234 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
