Alexander Wels has posted comments on this change. Change subject: frontend: Add infrastructure for Console Foreign Menu ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38986/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUiCommonModule.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUiCommonModule.java: Line 30: */ Line 31: public abstract class BaseUiCommonModule extends AbstractGinModule { Line 32: Line 33: protected void bindCommonIntegration() { Line 34: bind(ITypeResolver.class).to(UiCommonDefaultTypeResolver.class).asEagerSingleton(); What is the reason this needs to be an eager singleton? Line 35: bind(FrontendEventsHandlerImpl.class).in(Singleton.class); Line 36: bind(FrontendFailureEventListener.class).in(Singleton.class); Line 37: bind(ILogger.class).to(LoggerImpl.class).in(Singleton.class); Line 38: -- To view, visit https://gerrit.ovirt.org/38986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0cc2a2fd462bd8dc9085b300ec12fe46ff4518 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
