Maor Lipchuk has posted comments on this change.
Change subject: core: RemoveSnapshotSingleDisk ConcreteCreateTask
......................................................................
Patch Set 5: Looks good to me, approved
(1 inline comment)
minor comment
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
Line 92: // No op for test
Line 93: }
Line 94:
Line 95: },
Line 96: new RemoveSnapshotSingleDiskCommand(new
ImagesContainterParametersBase()) {
Consider refactor this to a method
Line 97: @Override
Line 98: protected void
initContainerDetails(ImagesContainterParametersBase parameters) {
Line 99: // No op for test
Line 100: }
--
To view, visit http://gerrit.ovirt.org/7798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9eb4f2b87832de1418297a543ee33570d044c93
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
