Juan Hernandez has posted comments on this change.
Change subject: utils: cleanup: SSHClient: add properties get methods
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment inside.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java
Line 220: return this.user;
Line 221: }
Line 222:
Line 223: public String getDisplayHost() {
Line 224: StringBuffer ret = new StringBuffer(100);
StringBuilder is better here, it avoids synchronizations that you don't need in
a local variable like this one.
Line 225: if (this.host == null) {
Line 226: ret.append("N/A");
Line 227: }
Line 228: else {
--
To view, visit http://gerrit.ovirt.org/8009
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I236d6b71402b840b9c338c255b16e298cd0716fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
