Moti Asayag has posted comments on this change. Change subject: core: Make DAOs injectable ......................................................................
Patch Set 13: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/38505/13/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java: Line 46: import static org.junit.Assert.assertEquals; Line 47: import static org.junit.Assert.assertFalse; Line 48: import static org.junit.Assert.assertNotNull; Line 49: import static org.junit.Assert.assertTrue; Line 50: import static org.junit.Assert.fail; the static import comes prior to the regular imports according to the formatter (at least in eclipse this is the way it works), but that's real minor and could be changed later. Line 51: Line 52: public class DbFacadeDAOTest extends BaseDAOTestCase { Line 53: Line 54: // entity IDs for testing retrieving an entity by id and type -- To view, visit https://gerrit.ovirt.org/38505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic426126d690ab6dedb49ef6b67deeba67661d031 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
