Michal Skrivanek has posted comments on this change.

Change subject: frontend: Pass JSESSIONID in VV file
......................................................................


Patch Set 17:

(1 comment)

https://gerrit.ovirt.org/#/c/33770/17/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java:

Line 51:     protected void writeOVirtSection(StringBuilder configBuilder) {
Line 52:         configBuilder.append("\n[ovirt]") //$NON-NLS-1$
Line 53:                 .append("\nhost=").append(engineHost) //$NON-NLS-1$
Line 54:                 .append("\nvm-guid=").append(vmId.toString()) 
//$NON-NLS-1$
Line 55:                 .append("\njsessionid=").append(sessionId) 
//$NON-NLS-1$
> once again, considering virt-viewer is of redhat there is no reason why a n
we can, and will, change it.
but we have to support existing clients in any case.
How fast we change it depends on the readiness of the sso redesign and release 
schedules synchronization
Line 56:                 .append("\nadmin=").append(Boolean.valueOf(admin)); 
//$NON-NLS-1$
Line 57:     }


-- 
To view, visit https://gerrit.ovirt.org/33770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5c6d2c91b99240527760b57a6079b5f986aff5b
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to