Vered Volansky has posted comments on this change.
Change subject: core: RemoveImage's ConcreteCreateTask
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
Line 70: protected void
initContainerDetails(ImagesContainterParametersBase parameters) {
Line 71: // No op for test
Line 72: }
Line 73: },
Line 74: new RemoveImageCommand(new RemoveImageParameters()) {
I agree, it's getting long and will only get longer
Line 75: @Override
Line 76: protected void
initContainerDetails(ImagesContainterParametersBase parameters) {
Line 77: // No op for test
Line 78: }
--
To view, visit http://gerrit.ovirt.org/7797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64a8bb2c121967216719e54117b073bffbcaafbf
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
