Vered Volansky has posted comments on this change.
Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation()
......................................................................
Patch Set 16: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 865: // Going to try and refresh the VM by re-loading
Line 866: // it form DB
Line 867: VM vm = getUpdatedVmForOperation();
Line 868: VM vmFromParams = getParameters().getVm();
Line 869: if (getVm() != null) {
Wouldn't it be better if it were vm instead of getVM() now that the new method
was used?
Line 870: VmHandler.UnLockVm(getVm());
Line 871: for (DiskImage disk : imageList) {
Line 872:
DbFacade.getInstance().getDiskImageDynamicDAO().remove(disk.getImageId());
Line 873:
DbFacade.getInstance().getImageDao().remove(disk.getImageId());
--
To view, visit http://gerrit.ovirt.org/6507
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f53af1324fc1aed32bdf8ec1eac9b7f7d307f25
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
