Kanagaraj M has uploaded a new change for review. Change subject: engine: Fixing gluster volume CIFS export configuration ......................................................................
engine: Fixing gluster volume CIFS export configuration when the user wants to export a volume through CIFS protocol, an option 'user.cifs=on' needs to be set. There were some confusions regarding 'on' and 'off', it is fixed now. Change-Id: Ied95cf5f95a467c82d25b4499982c46a0d7c6657 Signed-off-by: Kanagaraj M <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/8032/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java index aea6b33..1a1c723 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java @@ -323,17 +323,17 @@ public void enableCifs() { accessProtocols.add(AccessProtocol.CIFS); - setOption(GlusterConstants.OPTION_CIFS_DISABLE, GlusterConstants.OFF); + setOption(GlusterConstants.OPTION_USER_CIFS, GlusterConstants.ON); } public void disableCifs() { accessProtocols.remove(AccessProtocol.CIFS); - setOption(GlusterConstants.OPTION_CIFS_DISABLE, GlusterConstants.ON); + setOption(GlusterConstants.OPTION_USER_CIFS, GlusterConstants.OFF); } public boolean isCifsEnabled() { - String cifsEnabled = getOptionValue(GlusterConstants.OPTION_CIFS_DISABLE); - return (cifsEnabled == null || cifsEnabled.equalsIgnoreCase(GlusterConstants.OFF)); + String cifsEnabled = getOptionValue(GlusterConstants.OPTION_USER_CIFS); + return (cifsEnabled == null || cifsEnabled.equalsIgnoreCase(GlusterConstants.ON)); } public List<String> getBrickDirectories() { diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java index 2ae4599..ed417ac 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java @@ -6,7 +6,7 @@ public static final String OPTION_AUTH_ALLOW = "auth.allow"; public static final String OPTION_NFS_DISABLE = "nfs.disable"; - public static final String OPTION_CIFS_DISABLE = "user.cifs"; + public static final String OPTION_USER_CIFS = "user.cifs"; public static final int DEFAULT_REPLICA_COUNT = 2; public static final int DEFAULT_STRIPE_COUNT = 4; -- To view, visit http://gerrit.ovirt.org/8032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ied95cf5f95a467c82d25b4499982c46a0d7c6657 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
