Alona Kaplan has posted comments on this change. Change subject: engine: introduce UpdateHostNicVfsConfigCommand ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/36843/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfsConfigCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfsConfigCommandBase.java: Line 34: && validate(getVfsConfigValidator().nicSriovEnabled()) Line 35: && validate(getVfsConfigValidator().sriovFeatureSupported()); Line 36: } Line 37: Line 38: public InterfaceDao getInterfaceDao() { > now with injectable dao patch is merged, you should replace those getXXXDao Didn't remove the getter since it is used by the tests. Line 39: return getDbFacade().getInterfaceDao(); Line 40: } Line 41: Line 42: public HostNicVfsConfigDao getVfsConfigDao() { -- To view, visit https://gerrit.ovirt.org/36843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I868d58b291c3920f6cf966a409a11a06498854b1 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
