Allon Mureinik has posted comments on this change.
Change subject: core: Removind uses deactivate from error flows at engine side
......................................................................
Patch Set 5: (4 inline comments)
basically +1, see minor issues inline.
Also, I'd separate all the places you fixed * imports, FQCNs and
ArrayList->List to separate patches.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java
Line 22: import org.ovirt.engine.core.dal.dbbroker.DbFacade;
Line 23: import org.ovirt.engine.core.utils.transaction.TransactionMethod;
Line 24: import org.ovirt.engine.core.utils.transaction.TransactionSupport;
Line 25:
Line 26: @LockIdNameAttribute
Question: since the call to compensate() (line 100 in the original file) was
removed, do we still need forceCompensation=true?
Line 27: @NonTransactiveCommandAttribute(forceCompensation=true)
Line 28: public class ActivateStorageDomainCommand<T extends
StorageDomainPoolParametersBase> extends
Line 29: StorageDomainCommandBase<T> {
Line 30:
....................................................
Commit Message
Line 3: AuthorDate: 2012-09-16 10:45:43 +0300
Line 4: Commit: Michael Kublin <[email protected]>
Line 5: CommitDate: 2012-09-16 10:45:43 +0300
Line 6:
Line 7: core: Removind uses deactivate from error flows at engine side
s/Removind uses deactivate/Removed usages of deactivate/
Line 8:
Line 9: The following patch will remove the following things at engine side:
Line 10: 1. Disconnect call from storage server, from now will be called only
Line 11: during maintaince or remove storage domain flows
Line 9: The following patch will remove the following things at engine side:
Line 10: 1. Disconnect call from storage server, from now will be called only
Line 11: during maintaince or remove storage domain flows
Line 12: 2. Deactivate call will be called only during maintaince flow.
Line 13: 3. Error flow: if a flow is a problematic, it will be moved to
InActive state
s/InActive/Inactive/
Line 14: only at engine side (DB update only) with out a call to vdsm
Line 15: 4. Recovery: if domain is seem ok by one of the vdsms it will be
automaticlly moved
Line 16: to Active status (DB upodate only)
Line 17: 5. Removed unused flows.
Line 11: during maintaince or remove storage domain flows
Line 12: 2. Deactivate call will be called only during maintaince flow.
Line 13: 3. Error flow: if a flow is a problematic, it will be moved to
InActive state
Line 14: only at engine side (DB update only) with out a call to vdsm
Line 15: 4. Recovery: if domain is seem ok by one of the vdsms it will be
automaticlly moved
s/is seem ok/seems to be OK/
Line 16: to Active status (DB upodate only)
Line 17: 5. Removed unused flows.
Line 18:
Line 19: Change-Id: I87be747a32ae38f21091a07de664396cdbbf98c9
--
To view, visit http://gerrit.ovirt.org/7257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87be747a32ae38f21091a07de664396cdbbf98c9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
