Alon Bar-Lev has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/37886/18/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java: Line 128: throw new ExitException( Line 129: String.format("Argument(s) '%1$s' required", StringUtils.join(mandatory, ", ")), Line 130: 1 Line 131: ); Line 132: } > Yes, but then when user use sequence such as: ok, it took me a while to understand, sorry. so indeed we need to have: prefix.arg.help.parse-stop = true prefix.arg.version.parse-stop = true or: prefix.parse-stop.arg = help so that parser will know to handle this parameter in a special way. I think that the 2nd form is easier to parse as you can reach to help directly. but this is not for help only... --version should also be treaded like so, so the 1st is more flexible. I tried to remember how it is with getopt_long(), and as it return a parameter at time, it is immune to this... Line 133: others.addAll(args); Line 134: argMap.put("__other__", others); Line 135: Line 136: return argMap; -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ondra Machacek <[email protected]> Gerrit-Reviewer: Ondřej Macháček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
