Eli Mesika has posted comments on this change. Change subject: core: [RFE]Backup Awareness - BE ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/39524/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupHistory.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupHistory.java: Line 1: package org.ovirt.engine.core.common.businessentities; Line 2: Line 3: import org.ovirt.engine.core.common.utils.ObjectUtils; > now that gwt supports jave-1.7 you can use java.util.Objects instead will fix Line 4: Line 5: import java.io.Serializable; Line 6: import java.util.Date; Line 7: Line 4: Line 5: import java.io.Serializable; Line 6: import java.util.Date; Line 7: Line 8: public class EngineBackupHistory extends IVdcQueryable implements Serializable { > rename to EngineBackupLog ? will fix Line 9: Line 10: private String dbName; Line 11: private Date doneAt; Line 12: private boolean passed; Line 9: Line 10: private String dbName; Line 11: private Date doneAt; Line 12: private boolean passed; Line 13: private String outputMessage; > rename to backupMessage ? No, see my other comments regarding that Line 14: Line 15: public String getDbName() { Line 16: return dbName; Line 17: } Line 70: return (ObjectUtils.objectsEqual(dbName, other.dbName) Line 71: && ObjectUtils.objectsEqual(doneAt, other.doneAt) Line 72: && this.passed == other.passed Line 73: && ObjectUtils.objectsEqual(outputMessage, other.outputMessage)); Line 74: } > please add implementation for toString() which help during debug. Will probably use for that the ToStringBuilder that Martin wrote -- To view, visit https://gerrit.ovirt.org/39524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3ca5ba16d1eaaa10c48e1391a2d606a152926b6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
