anmolbabu has posted comments on this change. Change subject: webadmin: changed confirmation message restore snapshot popup ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39566/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java: Line 248: setConfirmWindow(model); Line 249: model.setTitle(ConstantsManager.getInstance().getMessages().confirmRestoreSnapshot(getEntity().getName())); Line 250: model.setHelpTag(HelpTag.volume_restore_snapshot_confirmation); Line 251: model.setHashName("volume_restore_snapshot_confirmation"); //$NON-NLS-1$ Line 252: model.setMessage(ConstantsManager.getInstance().getConstants().confirmVolumeSnapshotRestoreMesage()); I might be wrong in understanding the bug. Correct me if I'am wrong. But, the bug says "Message in the Restore Popup is not correct when volume is online and snapshot is deactivated" and lets assume now that the snapshot is deactivated and then without this change it would go into the else which is doing the same as your change already right? Line 253: UICommand okCommand = UICommand.createDefaultOkUiCommand("onRestoreSnapshot", this); //$NON-NLS-1$ Line 254: model.getCommands().add(okCommand); Line 255: UICommand cancelCommand = UICommand.createCancelUiCommand("cancelConfirmation", this); //$NON-NLS-1$ Line 256: model.getCommands().add(cancelCommand); -- To view, visit https://gerrit.ovirt.org/39566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34d27eed4d24c039bbe74c0b165e6a6dce9baa95 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Karnan t c <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
