Vojtech Szocs has posted comments on this change.
Change subject: build: pack gwt-symbols within jar
......................................................................
Patch Set 2:
>> Not sure if <dependencies> in frontend-symbols/pom.xml is needed at all (due
>> to using resource copying) but overall looks good.
> we must make sure these we have the symbols, before adding into jar, no?
Let me try to explain on example. Let's say we have a Maven project with root
pom.xml like this:
<project>
<name>example-root</name>
<modules>
<module>example-A</module>
<module>example-B</module>
</modules>
</project>
when you run "mvn" command in Maven project's root directory (where root
pom.xml is located), the build order will *always* be following:
example-root
example-A
example-B
In other words, build order of individual Maven modules is statically
determined through pom.xml files.
Dependency declarations are typically used to put other modules on classpath of
given module when compiling (javac) that given module. Dependencies of module X
are resolved (pulled from local Maven repository) *only* when module X is built
-- they do *not* have any influence on module build order.
frontend-symbols module doesn't contain any source files, it just uses Maven
resource copying to pull in files from other directories. The <dependencies>
declaration in frontend-symbols module therefore doesn't have any impact on
build order. See frontend/webadmin/modules/pom.xml - frontend-symbols module is
always built after userportal-gwt module.
--
To view, visit https://gerrit.ovirt.org/39118
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I489c154859d2092c844d6798a339959baa63a0ce
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
