Hello anmolbabu,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/39667
to review the following change.
Change subject: engine : Added missing error codes
......................................................................
engine : Added missing error codes
This patch adds a generic geo-rep exception
which is the generic parent of all geo-replication
exceptions exposed by the vdsm.
Change-Id: I6ed434a3d6eaca4609c5b5a2c736b8c2330068d6
Signed-off-by: Anmol Babu <[email protected]>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
4 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/67/39667/1
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
index b05bff6..adddcc9 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
@@ -376,6 +376,7 @@
GlusterVolumeProfileStopFailed(4159),
GlusterVolumeProfileInfoFailed(4160),
GlusterVolumeStatusAllFailedException(4161),
+ GlusterGeoRepException(4200),
GlusterVolumeGeoRepSessionStartFailed(4201),
GlusterVolumeGeoRepSessionStopFailed(4202),
GlusterVolumeGeoRepStatusFailed(4203),
diff --git
a/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
b/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
index 6038436..02286ec 100644
---
a/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
+++
b/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
@@ -336,6 +336,7 @@
GlusterVolumeRebalanceStopFailed=Gluster Volume Rebalance Stop Failed
GlusterVolumeGeoRepSessionStartFailed=Failed to start geo-replication session
for volume
GlusterVolumeGeoRepSessionResumeFailed=Volume Geo-Replication Resume Failed
+GlusterGeoRepException=Gluster Geo-Replication Exception
GlusterVolumeDeleteFailed=Gluster Volume Delete Failed
GlusterVolumeReplaceBrickStartFailed=Gluster Volume Replace Brick Start Failed
GlusterVolumeListFailed=Failed to fetch Gluster Volume List
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
index 1a7615c..c2f09f9 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
@@ -65,6 +65,7 @@
case GlusterVolumeStatusAllFailedException:
case GlusterVolumeRebalanceStatusFailedException:
case GlusterVolumeGeoRepSessionResumeFailed:
+ case GlusterGeoRepException:
case GlusterVolumeRemoveBricksStartFailed:
case GlusterVolumeRemoveBricksStopFailed:
case GlusterVolumeRemoveBrickStatusFailed:
diff --git
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
index a14cfb6..a063de9 100644
---
a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
+++
b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
@@ -724,6 +724,9 @@
@DefaultStringValue("Resume of geo-replication session failed on gluster
volume")
String GlusterVolumeGeoRepSessionResumeFailed();
+ @DefaultStringValue("Gluster Geo-Replication Exception")
+ String GlusterGeoRepException();
+
@DefaultStringValue("Gluster Volume Rebalance Stop Failed.")
String GlusterVolumeRebalanceStopFailed();
--
To view, visit https://gerrit.ovirt.org/39667
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ed434a3d6eaca4609c5b5a2c736b8c2330068d6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
