Yair Zaslavsky has posted comments on this change.

Change subject: engine: Remove multiple entities with single query
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File backend/manager/dbscripts/gluster_volumes_sp.sql
Line 198:     RETURNS VOID
Line 199:     AS $procedure$
Line 200: BEGIN
Line 201:     DELETE FROM gluster_volumes
Line 202:     WHERE id::VARCHAR = any 
(string_to_array(v_volume_ids,',')::VARCHAR[] );
Have you considered using the fnSplitterUuid function we have at 
create_functions.sp?
Line 203: END; $procedure$
Line 204: LANGUAGE plpgsql;
Line 205: 
Line 206: 


--
To view, visit http://gerrit.ovirt.org/8118
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3a1d873807952a154c970860933daa43058cf63
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to