Sandro Bonazzola has posted comments on this change. Change subject: hosted-engine: allow to deploy hosted-engine ......................................................................
Patch Set 17: (3 comments) https://gerrit.ovirt.org/#/c/38547/17/src/plugins/ovirt-host-deploy/hosted-engine/packages.py File src/plugins/ovirt-host-deploy/hosted-engine/packages.py: Line 83: ) Line 84: def _closeup(self): Line 85: ha_services = ('ovirt-ha-agent',) Line 86: if not self.services.supportsDependency: Line 87: ha_services = ('ovirt-ha-broker', 'ovirt-ha-agent') > append only ovirt-ha-broker? Done Line 88: for service in ha_services: Line 89: self.services.startup( Line 90: name=service, Line 91: state=self.environment[ Line 89: self.services.startup( Line 90: name=service, Line 91: state=self.environment[ Line 92: odeploycons.HostedEngineEnv.ENABLE Line 93: ], > sysvinit can just call service <dependency> start to make sure dependency Done Line 94: ) Line 95: self.services.state( Line 96: name=service, Line 97: state=False, Line 95: self.services.state( Line 96: name=service, Line 97: state=False, Line 98: ) Line 99: if self.environment[odeploycons.HostedEngineEnv.ENABLE]: > I am referring to a state that engine1 has hosted engine at host1, then the I think we can take this discussion offline, but I don't understand how do you move host1 which is running engine1 from the management of engine1 to the management of engine2 without moving to maintenance host1 (causing engine1 to migrate to another host) and removing the host from engine1 (and we need to be sure that this can be done only if hosted engine support is disabled first, on engine side UX) Line 100: self.services.state( Line 101: name=service, Line 102: state=True, Line 103: ) -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
