Alon Bar-Lev has posted comments on this change. Change subject: hosted-engine: configure gluster for HC ......................................................................
Patch Set 1: (1 comment) once again we should discuss the modifying of system state by this and not reverting when not installed. can't it dynamically being set if required? why do we force a specific port and not leave the default? https://gerrit.ovirt.org/#/c/39678/1/src/plugins/ovirt-host-deploy/hosted-engine/glusterd.py File src/plugins/ovirt-host-deploy/hosted-engine/glusterd.py: Line 65: continue Line 66: elif line.find('end-volume') == 0: Line 67: content.append(' option rpc-auth-allow-insecure on') Line 68: content.append(' option base-port 49217') Line 69: content.append(line) I do not know what format this file has, but comments and such should be managed. Line 70: Line 71: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 72: filetransaction.FileTransaction( Line 73: name=odeploycons.FileLocations.GLUSTERD_VOL, -- To view, visit https://gerrit.ovirt.org/39678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bded0891309a2d38daef76bac93c7c7a4b0602a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Vijay Bellur <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
