Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: UI Plugins PoC, revision 5
......................................................................
Patch Set 1: (1 inline comment)
Minor comment at core part.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ServletUtils.java
Line 49: public static boolean isSane(String path) {
Line 50: // Check that the path is not too long:
Line 51: final int lenght = path.length();
Line 52: if (lenght > PATH_MAX) {
Line 53: log.error("The path is " + lenght + " characters long,
which is longer than the maximum allowed " + PATH_MAX + ".");
s/lenght/length
Line 54: return false;
Line 55: }
Line 56:
Line 57: // Check that there aren't potentially dangerous directory
navigation sequences:
--
To view, visit http://gerrit.ovirt.org/8120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbf7659f023d8929fb0a8303061851bb7ee555bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
