Alon Bar-Lev has posted comments on this change. Change subject: hosted-engine: allow to deploy hosted-engine ......................................................................
Patch Set 20: (2 comments) I my-self had done this differently... all modules that enable - leave it as they are, they are active only if enabled, per what we do in all other modules. add a disable module that if not enabled, override file with empty and stop the service. but even if not this way, separate between the stages so avoiding conditionals. https://gerrit.ovirt.org/#/c/38547/20/src/plugins/ovirt-host-deploy/hosted-engine/configureha.py File src/plugins/ovirt-host-deploy/hosted-engine/configureha.py: Line 58: modifiedList=self.environment[ Line 59: otopicons.CoreEnv.MODIFIED_FILES Line 60: ], Line 61: ), Line 62: ) why not have two miscs one for each with different condition? Line 63: else: Line 64: self.logger.info(_('Updating hosted-engine configuration')) Line 65: content = ( Line 66: 'ca_cert={ca_cert}\n' Line 100: ], Line 101: ) Line 102: def _closeup(self): Line 103: if os.path.exists(odeploycons.FileLocations.HOSTED_ENGINE_CONF): Line 104: os.unlink(odeploycons.FileLocations.HOSTED_ENGINE_CONF) are you sure this is required, maybe just leave it empty? Line 105: Line 106: -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
