Kiril Nesenko has posted comments on this change. Change subject: tools: Fix default port (BZ857480) ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (3 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2012-09-14 10:54:02 -0400 Line 4: Commit: Keith Robertson <[email protected]> Line 5: CommitDate: 2012-09-14 11:13:33 -0400 Line 6: Line 7: tools: Fix default port (BZ857480) I think you should improve a commit message. Changed default port to 443 instead of 8443. Line 8: Line 9: Change-Id: Idab93219597d8199ffb79a0c7c664c6369c0416a .................................................... File src/engine-iso-uploader.py Line 740: self.caller.call(cmd) Line 741: self.rename_file_ssh(user, address, temp_dest_file, dest_file) Line 742: # Force oVirt Engine to refresh the list of files in the ISO domain Line 743: self.refresh_iso_domain(id) Line 744: logging.info(_("%s uploaded successfully") % file) I think you should fix this in another patch, because it is not related to the bz itself Line 745: else: Line 746: logging.error(_('There is not enough space in %s (%s bytes) for %s (%s bytes)' % Line 747: (path, dir_size, file, file_size))) Line 748: else: Line 785: NUMERIC_VDSM_ID) Line 786: # Force oVirt Engine to refresh the list of files in the ISO domain Line 787: if id is not None: Line 788: self.refresh_iso_domain(id) Line 789: logging.info(_("%s uploaded successfully") % file) I think you should fix this in another patch, because it is not related to the bz itself Line 790: else: Line 791: logging.error(_('There is not enough space in %s (%s bytes) for %s (%s bytes)' % Line 792: (path, dir_size, file, file_size))) Line 793: except Exception, e: -- To view, visit http://gerrit.ovirt.org/8007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idab93219597d8199ffb79a0c7c664c6369c0416a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Keith Robertson <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
