Alona Kaplan has posted comments on this change. Change subject: engine: scheduling host- find free VF ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/37931/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java: Line 526: if (hostList == null || hostList.isEmpty()) { Line 527: break; Line 528: } Line 529: filterPolicyUnit.setMemoryChecker(memoryChecker); Line 530: filterPolicyUnit.setHostToVnicToVfMap(hostToVnicToVfMap); > i think this is wrong. what basically happens here is enforcement of each P I agree with you. But it is the current design and not related directly to this patch. I will discuss it with SLA team a will (or they will:)) send a new patch with the redesign. Line 531: List<VDS> currentHostList = new ArrayList<VDS>(hostList); Line 532: hostList = filterPolicyUnit.filter(hostList, vm, parameters, result.getDetails()); Line 533: logFilterActions(currentHostList, Line 534: toIdSet(hostList), -- To view, visit https://gerrit.ovirt.org/37931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58c7aaa7a5a7160132418c397840583209aa8371 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
