Ramesh N has uploaded a new change for review. Change subject: webadmin: fix build issue in VolumeModule ......................................................................
webadmin: fix build issue in VolumeModule @Provides and @Singleton is missing for getVolumeSnapshotListProvider method in voloume module. GWT build is failing because of this issue. Fixing this issue with this patch Change-Id: I6e9abd38c1dc6eb72a4d6e9f0b594a036d6eb28a Signed-off-by: Ramesh Nachimuthu <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/39716/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java index 10640d8..85176bc 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java @@ -166,10 +166,11 @@ }; } + + @Provides + @Singleton public SearchableDetailModelProvider<GlusterVolumeSnapshotEntity, VolumeListModel, GlusterVolumeSnapshotListModel> getVolumeSnapshotListProvider(EventBus eventBus, - Provider<DefaultConfirmationPopupPresenterWidget> defaultConfirmPopupProvider, - final Provider<VolumeListModel> mainModelProvider, - final Provider<GlusterVolumeSnapshotListModel> modelProvider) { + Provider<DefaultConfirmationPopupPresenterWidget> defaultConfirmPopupProvider) { return new SearchableDetailTabModelProvider<GlusterVolumeSnapshotEntity, VolumeListModel, GlusterVolumeSnapshotListModel>(eventBus, defaultConfirmPopupProvider, VolumeListModel.class, @@ -187,6 +188,7 @@ return super.getConfirmModelPopup(source, lastExecutedCommand); } }; + } @Provides @@ -270,7 +272,6 @@ @Override protected void configure() { - bind(GlusterVolumeSnapshotListModel.class).in(Singleton.class); } } -- To view, visit https://gerrit.ovirt.org/39716 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6e9abd38c1dc6eb72a4d6e9f0b594a036d6eb28a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
