Allon Mureinik has posted comments on this change.
Change subject: core: log domain name during error in irsbroker (#854025)
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
minor comment, see inline
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1445: _disposed = true;
Line 1446: }
Line 1447: }
Line 1448:
Line 1449: private String getDomainIdTuple(Guid domainId) {
this should be static.
Line 1450: storage_domain_static storage_domain =
DbFacade.getInstance().getStorageDomainStaticDAO().get(domainId);
Line 1451: if (storage_domain != null) {
Line 1452: return domainId + ":" +
storage_domain.getstorage_name();
Line 1453: } else {
--
To view, visit http://gerrit.ovirt.org/7998
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1943d779237c686a21ea74168ed48a0ac45c202
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
