Allon Mureinik has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java
Line 8: import org.ovirt.engine.core.common.vdscommands.VDSParametersBase;
Line 9: import org.ovirt.engine.core.common.vdscommands.VDSReturnValue;
Line 10: import org.ovirt.engine.core.compat.Guid;
Line 11:
Line 12: public abstract class AbstractSPMAsyncTaskHandler<C extends
CommandBase<?>> implements SPMAsyncTaskHandler {
indeed, it is not used here - it is presented here for ease of review, to
explain how handlers are used.
Actual usages will be introduced in subsequent patches.
Note that this is a WIP patch - when we have a whole solution, the patchset
will be restructured.
Line 13:
Line 14: private C cmd;
Line 15:
Line 16: public AbstractSPMAsyncTaskHandler(C cmd) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 494: }
Line 495:
Line 496: private void internalEndSuccessfully() {
Line 497: log.infoFormat("Ending command successfully: {0}",
getClass().getName());
Line 498: endSuccessfully();
endSuccessfully() should not be called here - this is a rebase mistake, and
will be fixed in subsequent patches.
Line 499: getCurrentTaskHandler().endSuccessfully();
Line 500: getParameters().incrementExecutionIndex();
Line 501: if (getExecutionIndex() < getTaskHandlers().size()) {
Line 502: executeAction();
--
To view, visit http://gerrit.ovirt.org/7956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
