Eli Mesika has posted comments on this change. Change subject: gluster: add is_gluster_brick flag to storage device ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/39598/1/packaging/dbscripts/storage_device_sp.sql File packaging/dbscripts/storage_device_sp.sql: Line 14: v_filesystem_type VARCHAR(50), Line 15: v_mount_point VARCHAR(4096), Line 16: v_size BIGINT, Line 17: v_is_free BOOLEAN, Line 18: v_is_gluster_brick BOOLEAN) is the is_gluster_brick not updateable ??? Line 19: RETURNS VOID Line 20: AS $procedure$ Line 21: BEGIN Line 22: INSERT INTO storage_device(id, name, device_uuid, filesystem_uuid, vds_id, https://gerrit.ovirt.org/#/c/39598/1/packaging/dbscripts/upgrade/03_06_1170_add_is_brick_flag-to_storage_device_table.sql File packaging/dbscripts/upgrade/03_06_1170_add_is_brick_flag-to_storage_device_table.sql: Line 1: select fn_db_add_column('storage_device', 'is_gluster_brick', 'BOOLEAN'); I think you should give a DEFAULT false here -- To view, visit https://gerrit.ovirt.org/39598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I375a7340eb76db9cf2bbf142923929bf9ede748a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
