anmolbabu has uploaded a new change for review. Change subject: engine: Mount-Broker setup on only one node. ......................................................................
engine: Mount-Broker setup on only one node. Previously mount broker setup used to be done on all nodes of slave volume. But, it was observed that with latest glusterfs nightly it suffices to do it on any one node in slave volume. And if its done on all nodes of slave volume, the glusterds enter a race condition as all of them simultaneously also try to set up mount broker on other nodes. Change-Id: I09f44f8f12e5a49a85b3542793aa5f476ab0ccb3 Signed-off-by: Anmol Babu <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java 1 file changed, 2 insertions(+), 20 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/70/39770/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java index c59a2f7..85377e7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java @@ -134,26 +134,8 @@ } private boolean setUpMountBrokerOnSlaves() { - List<Callable<Boolean>> mountBrokerSetupReturnStatuses = new ArrayList<>(); - for (final VDS currentSlaveServer : remoteServersSet) { - mountBrokerSetupReturnStatuses.add(new Callable<Boolean>() { - @Override - public Boolean call() throws Exception { - return getBackend().runInternalAction(VdcActionType.SetupGlusterGeoRepMountBrokerInternal, - new SetUpMountBrokerParameters(currentSlaveServer.getId(), - getParameters().getSlaveVolumeName(), - getParameters().getUserName(), - getParameters().getUserGroup())).getSucceeded(); - } - }); - } - List<Boolean> returnStatuses = ThreadPoolUtil.invokeAll(mountBrokerSetupReturnStatuses); - for (Boolean currentReturnStatus : returnStatuses) { - if (!currentReturnStatus) { - return false; - } - } - return true; + return getBackend().runInternalAction(VdcActionType.SetupGlusterGeoRepMountBrokerInternal, + new SetUpMountBrokerParameters(getVdsDAO().getByName(getParameters().getSlaveHost()).getId(), getParameters().getSlaveVolumeName(), getParameters().getUserName(), getParameters().getUserGroup())).getSucceeded(); } private boolean setUpPasswordlessSSHAndCreateSession() { -- To view, visit https://gerrit.ovirt.org/39770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I09f44f8f12e5a49a85b3542793aa5f476ab0ccb3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
