Michael Pasternak has posted comments on this change.

Change subject: restapi: schema add missing minOccurs, maxOccurs
......................................................................


Patch Set 1: Do not submit

while this true for client->server direction, this won't work for the 
client<-server, as there may be some cases where we would like returning empty 
element <element/> to explicitly show that this element/collection is empty,

not assigning any value to it in mapper will produce <element/>, after your 
change it will be NULL.

what will break backward compatibility and create NPEs
in client's scripts.  

rather than forcibly making all elements NULLibale,
please fix elements mentioned in the path.

thanks.

--
To view, visit http://gerrit.ovirt.org/8155
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9130358465a9ae5f946246f5111ae917f9f6795
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to