Liron Aravot has posted comments on this change.
Change subject: core: Add scan domain query
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ScanDomainParameters.java
Line 9: public ScanDomainParameters(Guid sdUUID) {
Line 10: super();
Line 11: this.sdUUID = sdUUID;
Line 12: }
Line 13:
if it's recieved within the c'tor do we need to initiate it here?
Line 14: private Guid sdUUID = Guid.Empty;
Line 15:
Line 16: public Guid getDomainId() {
Line 17: return sdUUID;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetImagesListVDSCommandParameters.java
Line 11: public GetImagesListVDSCommandParameters(Guid sdUUID, Guid spUUID)
{
Line 12: super(spUUID);
Line 13: setStorageDomainId(sdUUID);
Line 14: }
Line 15:
why do we initiate storageDomainId anyway? if we get it in the ctor we don't
need to create a new Guid
Line 16: private Guid storageDomainId = new Guid();
Line 17:
Line 18: public Guid getStorageDomainId() {
Line 19: return storageDomainId;
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImagesListVDSCommand.java
Line 18: protected void ExecuteIrsBrokerCommand() {
Line 19: _result =
getIrsProxy().getImagesList(getParameters().getStorageDomainId().toString());
Line 20: ProceedProxyReturnValue();
Line 21: java.util.ArrayList<Guid> tempRetValue = new
java.util.ArrayList<Guid>(_result.mImageList.length);
Line 22: for (int i = 0; i < _result.mImageList.length; i++) {
I think it's better practice to use foreach.
Line 23: tempRetValue.add(new Guid(_result.mImageList[i]));
Line 24: }
Line 25: setReturnValue(tempRetValue);
Line 26: }
--
To view, visit http://gerrit.ovirt.org/8070
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ada1a6a030c090e872b2eb3f67ee9325f379963
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ricky Hopper <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
